Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(simple_planning_simulator): remove static odom tf publisher #7265

Conversation

maxime-clem
Copy link
Contributor

Description

The odom frame is not used in Autoware so this PR removes the odom static publisher from the simple_planning_simulator launch file.

Tests performed

Psim.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 4, 2024
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Jun 4, 2024
@maxime-clem maxime-clem force-pushed the refactor/simple_planning_simulator-rm_odom branch from d82edd2 to 88a2620 Compare June 6, 2024 01:24
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that PSIM is working after the changes.

@maxime-clem maxime-clem merged commit dd3a7a8 into autowarefoundation:main Jun 6, 2024
24 of 25 checks passed
@maxime-clem maxime-clem deleted the refactor/simple_planning_simulator-rm_odom branch June 6, 2024 03:51
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants